Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCollectioNode crash during performBatchUpdates if no preferredSize specified #341

Closed
ibarisic05 opened this issue Jun 8, 2017 · 1 comment

Comments

@ibarisic05
Copy link

Hi all, thanks for great lib. Found an crash under ASCollectionNode during performBatchUpdates insert statement if there is no preferredSize specified.
screen shot 2017-06-08 at 13 14 54

Issue I was facing was that I needed to return one empty ASCellNode and I was returning it as
return ASCellNode()
this was creating a crash that you can see at screenshot. After moving this code to snippet below, everything seems to work fine.
let node: ASCellNode = ASCellNode() node.style.preferredSize = UIScreen.main.bounds.size return node

Don't know if this is intended behaviour or not, but this one cost me some time. Hope this helps someone. Maybe putting some info on this one, or something similar.

If you need more info let me know. Credit for fix goes to ypogribnyi on Slack.

@Adlai-Holler
Copy link
Member

Hi @ibarisic05 thanks for the issue report! This was resolved in #348 by suppressing main-thread assertions during -debugDescription. Hope to see you around more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants