Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): 135 - Isolate CSS Styles #191

Merged
merged 6 commits into from
Nov 29, 2023

Conversation

HoyosJuan
Copy link
Member

Description

This PR solves issue #135 by removing most of the CSS rules applied to general HTML elements. It may be some other elements that stills get affected by the styles in the library.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan merged commit 68c1d81 into ThatOpen:main Nov 29, 2023
1 check passed
@HoyosJuan HoyosJuan deleted the 135-isolate-css-styles branch November 29, 2023 04:02
@HoyosJuan HoyosJuan changed the title fix: 135 - Isolate CSS Styles fix(components): 135 - Isolate CSS Styles Nov 29, 2023
@HoyosJuan HoyosJuan mentioned this pull request Nov 29, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant