Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: used internal variables on component dispose #271

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

HoyosJuan
Copy link
Member

Description

This PR takes care of complementing commit 83fc9ec by attending #267 (review).


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@HoyosJuan HoyosJuan added the bug Something isn't working label Jan 17, 2024
@HoyosJuan HoyosJuan merged commit 8ac695d into ThatOpen:main Jan 17, 2024
1 check passed
@HoyosJuan HoyosJuan deleted the 257-components-dispose-update branch January 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant