New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep a copy of the replied message instead of fetching and computing rendering of the reply message block #646

Closed

4 tasks

nikkothari22 opened this issue Jan 27, 2024 · 1 comment · Fixed by #663

Labels

🩻 backend enhancement Improvement Medium priority 🎨 UI

Member

nikkothari22 commented Jan 27, 2024 •

edited by prathameshkurunkar7

Loading

If a message is a reply to another, copy the trimmed text content of the original message in the new message, along with its ID.

Benefits of this:

Pagination is much easier since we don't need to fetch the original message separately.
Rendering is much faster since we don't have to use Tiptap to render the original message and neither do we have to trim the content on the frontend.
Original message can be deleted easily without doing any integrity checks.

Add a field for replied message content in Raven Message
On the frontend, swap the replied message block with a simple text block
When a message is replied to, copy over the content from the original message, trim it and store it in the new message
Run a patch migration on all existing messages

nikkothari22 added Improvement Medium priority 🎨 UI 🩻 backend labels

linear bot commented Jan 27, 2024

RAV-56 Keep a copy of the replied message instead of fetching and computing rendering of the reply message block

maige-app bot added the enhancement label

nikkothari22 mentioned this issue

chore: updated packages #662

Merged

nikkothari22 linked a pull request

that will close this issue

feat: use copied replied message for showing reply block #663

Merged

nikkothari22 closed this as completed in #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment