Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: (mobile) incorrect cropping of images #834

Closed
ankush opened this issue Apr 9, 2024 · 4 comments · Fixed by #835
Closed

bug: (mobile) incorrect cropping of images #834

ankush opened this issue Apr 9, 2024 · 4 comments · Fixed by #835

Comments

@ankush
Copy link

ankush commented Apr 9, 2024 •
edited
Loading

Latest version, Firefox mobile. The image is roughly 1:1 but gets cropped like this:

Screenshot_2024-04-10-00-26-53-79_3aea4af51f236e4932235fdada7d1643
@linear Linear
Copy link

linear bot commented Apr 9, 2024

RAV-166 bug: (mobile) incorrect cropping of images

@ankush
Copy link
Author

ankush commented Apr 9, 2024

Raw image if required

image2261bc

@ankush
Copy link
Author

ankush commented Apr 9, 2024

IMO barring extreme aspect ratios we shouldn't crop images almost ever (?)

@nikkothari22
Copy link
Member

IMO barring extreme aspect ratios we shouldn't crop images almost ever (?)

Yep. Seems like a recent bug via #769. Should be an easy fix though.

@nikkothari22 nikkothari22 linked a pull request Apr 9, 2024 that will close this issue
fix: maintain aspect ratio of image on mobile even with max width #835
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: maintain aspect ratio of image on mobile even with max width The-Commit-Company/raven
2 participants
@ankush @nikkothari22