Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all APIs that are not revalidating because of app-cache #909

Closed
nikkothari22 opened this issue May 6, 2024 · 0 comments · Fixed by #910
Closed

Review all APIs that are not revalidating because of app-cache #909

nikkothari22 opened this issue May 6, 2024 · 0 comments · Fixed by #910

Comments

@nikkothari22
Copy link
Member

Just found that the get_channels API is not revalidating since it's cached by SWR in localstorage. Ideally, all APIs should be revalidated on refresh, cache is just for reduced "wait" times.
@nikkothari22 nikkothari22 linked a pull request May 7, 2024 that will close this issue
fix: refetch channels and members on load #910
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: refetch channels and members on load The-Commit-Company/raven
1 participant
@nikkothari22