Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRT: resolve conflicts between frInst::getTransform and frInst::getUpdatedXform #5712

Open
osamahammad21 opened this issue Sep 9, 2024 · 6 comments · May be fixed by #6326
Open

DRT: resolve conflicts between frInst::getTransform and frInst::getUpdatedXform #5712

osamahammad21 opened this issue Sep 9, 2024 · 6 comments · May be fixed by #6326
Assignees
@bnmfw @osamahammad21
Labels
drt Detailed Routing

Comments

@osamahammad21
Copy link
Member

Description

The code in DRT keeps fluctuating between the use of getTransform and getUpdatedXform. getTransform cannot be applied directly to the master shapes as its offset is not the correct transform offset. In my opinion, getTransform is always wrong and useless, however some parts of the code get away with using it.

Suggested Solution

No response

Additional Context

No response
@osamahammad21 osamahammad21 added the drt Detailed Routing label Sep 9, 2024
@titan73
Copy link
Contributor

titan73 commented Sep 9, 2024

So the idea is to convert the code to always use getUpdatedXform and remove getTransform at the end?

@maliberty maliberty changed the title DRT: resole conflicts between frInst::getTransform and frInst::getUpdatedXform DRT: resolve conflicts between frInst::getTransform and frInst::getUpdatedXform Sep 9, 2024
@maliberty
Copy link
Member

What is the goal of getUpdatedXform? I'm used to seeing people use getTransform across hierarchies. Why do you think it is wrong?

@osamahammad21
Copy link
Member Author

getUpdatedXform returns the correct transform that should be applied to the master shapes. However, getTransform returns a wrong one, because its origin point is not the actual origin point but the lower left point of the instance. I am still managing to understand how it is used correctly.

@maliberty
Copy link
Member

Is the transform different from what you would get in DEF for the instance?

@osamahammad21
Copy link
Member Author

yes, thus the need for getUpdateXform.

@maliberty
Copy link
Member

getUpdatedXform is pretty ugly. Can we just use the normal transform and avoid all this? I'm concerned about how much of an impact it might have but haven't scoped it myself.

@bnmfw bnmfw mentioned this issue Nov 11, 2024
Merged
@bnmfw bnmfw linked a pull request Dec 8, 2024 that will close this issue
Draft
@bnmfw bnmfw mentioned this issue Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnmfw bnmfw

@osamahammad21 osamahammad21

Labels
drt Detailed Routing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

drt: elimination of getNoRotationTransform and drt::dbTransform bnmfw/OpenROAD_Bernardo_Sandoval
4 participants
@maliberty @titan73 @bnmfw @osamahammad21