Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple study codes #4 #5

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Multiple study codes #4 #5

wants to merge 9 commits into from

Conversation

Homuncoli
Copy link

@Homuncoli Homuncoli commented Oct 8, 2024 •
edited
Loading

This PR adds supports for multiple study codes so that user who are enrolled in multiple studies #4 can also use this extension.

On the request handling side of things this was really simple to add. Just adding a new field in the sendRegistration body.
This should work nicely and easily, but i was only able to test it with Diversity Skills and only 2 study codes to choose from. But i don't see any reason why it shouldn't work with more than that.

However the UI is implemented really crudely at the moment. Would appreciate any suggestion on how to communicate this to the user clearly and make it look more appealing.

image
image

@The-breakbar
Copy link
Owner

Thank you so much! I've been meaning to get around to this, but I've just been putting it off because of the needed UI changes. I was planning a small settings menu so it'll fit in there.

@The-breakbar The-breakbar linked an issue Oct 9, 2024 that may be closed by this pull request
Multiple study codes #4
Open
@The-breakbar The-breakbar changed the base branch from main to dev October 9, 2024 16:49
@The-breakbar
Copy link
Owner

I changed some minor things, but otherwise looks good to me 👍
For the UI I was thinking a small "Show Settings" text at the bottom, which you could click to show configuration details like this one. So like a collapsible that starts hidden. If you want to give it a go, I can give you more details, otherwise I'd merge and it'll be in the next release with the settings.

Additionally the study code should be stored in local storage so you don't have to type it every time, but I'll take care of that, because I've been meaning to refactor the local storage structure.

@Homuncoli
Copy link
Author

Thanks for the feedback!
If you want assistence with the UI changes, i am happy to help. Just let me know the specifics and i will see what i can do.

Additionally, storing the study-code in the local story seems like a really good idea. Looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple study codes
2 participants
@Homuncoli @The-breakbar