Additional intro blockchain doc #7974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rectified errors as image was not visible
Deleting the image as it is not getting accepted in PR merge
Deleting the image as it is not getting accepted in PR merge
Removed all image s in the document
algorithms-keeper
bot
added
awaiting reviews
for more information, see https://pre-commit.ci
CaedenPH
suggested changes
Nov 6, 2022
blockchain/README.md
Outdated
|
|
||
| Let's breakdown the terminologies in the above definition. We find below terminologies, | ||
|
|
||
| - Digital Ledger Technology(DLT) |
There was a problem hiding this comment.
Suggested change
| - Digital Ledger Technology(DLT) | |
| - Digital Ledger Technology (DLT) |
blockchain/README.md
Outdated
|
|
||
| It is otherwise called as distributed ledger technology. It is simply the opposite of centralized database. Firstly, what is a **ledger**? A ledger is a book or collection of accounts that records account transactions. | ||
|
|
||
| *Then why is Blockchain addressed as digital ledger when it can record more than account transactions?* *And what are other transactions and details it can hold?* |
There was a problem hiding this comment.
Suggested change
| *Then why is Blockchain addressed as digital ledger when it can record more than account transactions?* *And what are other transactions and details it can hold?* | |
| *Then why is Blockchain addressed as digital ledger when it can record more than account transactions? And what are other transactions and details it can hold?* |
blockchain/README.md
Outdated
|
|
||
| So this means even if tampered in one branch we can find out. If one branch is hacked we can be alerted and get to safeguard other branch. Now, assume these branches as computer or nodes and the ledger is a transaction record or digital receipt. so this is the concept of Digital Ledger Technology. | ||
|
|
||
| *Do all node needs all the info in others nodes? Does this increase storage space in all nodes?* |
There was a problem hiding this comment.
This doesn't make grammatical sense, please rephrase
blockchain/README.md
Outdated
|
|
||
| ## Blocks | ||
|
|
||
| In short a block is nothing but collections of records with a labelled header. These are connected cryptographically. Once a new block is added to a chain previous block is connected or precisely said as locked and will remain unaltered. we will see how this works once we dig deep into working mechanisms. |
There was a problem hiding this comment.
Suggested change
| In short a block is nothing but collections of records with a labelled header. These are connected cryptographically. Once a new block is added to a chain previous block is connected or precisely said as locked and will remain unaltered. we will see how this works once we dig deep into working mechanisms. | |
| In short a block is nothing but collections of records with a labelled header. These are connected cryptographically. Once a new block is added to a chain previous block is connected or precisely said as locked and will remain unaltered. We will see how this works once we dig deep into working mechanisms. |
There was a problem hiding this comment.
Hi, Thanks for the feedback. As per above suggestions, I did changes to the document and committed it to this PR. Please revert back if any other changes are required in the document.
Commited the suggested changes and submitting for review.
Changed a sentence that needed grammatical correction.
CaedenPH
approved these changes
Nov 9, 2022
|
Thank you for acknowledging my work. Hope to contribute more to the project. |
cclauss
reviewed
Nov 14, 2022
blockchain/README.md
Outdated
| @@ -1,7 +1,44 @@ | |||
| # Blockchain | |||
|
|
|||
| A Blockchain is a type of distributed ledger technology (DLT) that consists of growing list of records, called blocks, that are securely linked together using cryptography. | |||
| A Blockchain is a type of distributed ledger technology **(DLT)** that consists of growing list of records, called **blocks**, that are securely linked together using **cryptography**. | |||
There was a problem hiding this comment.
Suggested change
| A Blockchain is a type of distributed ledger technology **(DLT)** that consists of growing list of records, called **blocks**, that are securely linked together using **cryptography**. | |
| A Blockchain is a type of **distributed ledger** technology (DLT) that consists of growing list of records, called **blocks**, that are securely linked together using **cryptography**. |
There was a problem hiding this comment.
Thank you for the feedback. I have made the requested changes in this file. Please revert back if any other changes are required in the document.
Added the changes suggested by review panel
cclauss
approved these changes
Nov 15, 2022
algorithms-keeper
bot
removed
the
awaiting reviews
Cjkjvfnby
pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
* A deeper introduction to blockchain technology * Update README.md Rectified errors as image was not visible * Delete img1.jpg Deleting the image as it is not getting accepted in PR merge * Delete img2.jpg Deleting the image as it is not getting accepted in PR merge * Update README.md Removed all image s in the document * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update README.md Commited the suggested changes and submitting for review. * Update README.md Changed a sentence that needed grammatical correction. * Update README.md Added the changes suggested by review panel Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With respect to Blockchain File
Describe your change:
Checklist:
Fixes: #{6642}.