Skip to content

Remove duplicate Collatz sequence implementation #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tianyizheng02 opened this issue Dec 28, 2022 · 1 comment · Fixed by #8836
Closed

Remove duplicate Collatz sequence implementation #8061

tianyizheng02 opened this issue Dec 28, 2022 · 1 comment · Fixed by #8836
Labels
enhancement This PR modified some existing files

Comments

@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Dec 28, 2022 •
edited
Loading

Feature description

I think one of 3n_plus_1.py and collatz_sequence.py should be removed, as they're nearly identical implementations of the same algorithm for computing Collatz sequences.

I'm not sure which of the two files should be deleted. I believe that "the Collatz conjecture" is the more well-known name for the problem, but it seems that 3n_plus_1.py is the older of the two files.
@tianyizheng02 tianyizheng02 added the enhancement This PR modified some existing files label Dec 28, 2022
@Nomine-Nihil
Copy link

This I didn't see.. V C But I'm having trouble running and recognizing.. ??

@tianyizheng02 tianyizheng02 mentioned this issue Jun 24, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate implementation of Collatz sequence tianyizheng02/Python
2 participants
@tianyizheng02 @Nomine-Nihil