Refactor test cases to replace cancellable tasks with background tasks for improved performance

Author: TheAngryByrd

src/IcedTasks/AutoOpens.fs

@@ -17,11 +17,10 @@ module AutoOpens =
     [<assembly: AutoOpen("IcedTasks.ValueTasksUnit")>]
     [<assembly: AutoOpen("IcedTasks.ColdTasks")>]
     [<assembly: AutoOpen("IcedTasks.CancellableTaskBase")>]
+    [<assembly: AutoOpen("IcedTasks.CancellableValueTasks")>]
 #if NET6_0_OR_GREATER
     [<assembly: AutoOpen("IcedTasks.CancellablePoolingValueTasks")>]
 #endif
-    [<assembly: AutoOpen("IcedTasks.CancellableValueTasks")>]
-    [<assembly: AutoOpen("IcedTasks.CancellablePoolingValueTasks")>]
     [<assembly: AutoOpen("IcedTasks.CancellableTasks")>]
 #if NET10_0_OR_GREATER
     [<assembly: AutoOpen("IcedTasks.TaskBase_Net10")>]

tests/IcedTasks.Tests/CancellablePoolingValueTaskTests.fs

@@ -1045,7 +1045,7 @@ module CancellablePoolingValueTaskTests =
                         let parallelList = ResizeArray<_>()
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            cancellablePoolingValueTask {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow

tests/IcedTasks.Tests/CancellableTaskTests.fs

@@ -1012,7 +1012,7 @@ module CancellableTaskTests =
                         let parallelList = ResizeArray<_>()
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            cancellableTask {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow

tests/IcedTasks.Tests/CancellableValueTaskTests.fs

@@ -1047,7 +1047,7 @@ module CancellableValueTaskTests =
                         let parallelList = ResizeArray<_>()
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            cancellableValueTask {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow

tests/IcedTasks.Tests/Expect.fs

@@ -9,10 +9,12 @@ module Task =
     /// We run it max times to ensure it really gets async yielded.
     /// Alternative would be Task.Delay but can be slow.
     let yieldMany max =
-        task {
-            for _ = 0 to max do
-                do! Task.Yield()
-        }
+        Task.Run<unit>(fun _ ->
+            task {
+                for _ = 0 to max do
+                    do! Task.Yield()
+            }
+        )
 
 module TestHelpers =
     open System.Threading
@@ -73,6 +75,12 @@ module Expecto =
 module Expect =
     open Expecto
 
+    let inline isAssignableFrom<'t> (e: exn) =
+        let t1 = e.GetType()
+        let t2 = typeof<'t>
+
+        t2.IsAssignableFrom t1
+
     /// Expects the passed function to throw `'texn`.
     [<RequiresExplicitTypeArguments>]
     let throwsTAsync<'texn when 'texn :> exn> f message =
@@ -86,14 +94,16 @@ module Expect =
                         return ValueSome e
                 }
 
+
             match thrown with
-            | ValueSome e when not (e.GetType().IsAssignableFrom typeof<'texn>) ->
+            | ValueSome e when isAssignableFrom<'texn> e -> ()
+            | ValueSome e ->
                 failtestf
                     "%s. Expected f to throw an exn of type %s, but one of type %s was thrown."
                     message
                     (typeof<'texn>.FullName)
                     (e.GetType().FullName)
-            | ValueSome _ -> ()
+
             | _ -> failtestf "%s. Expected f to throw." message
         }
 

tests/IcedTasks.Tests/PoolingValueTaskTests.fs

@@ -689,7 +689,7 @@ module PoolingValueTaskTests =
                         let parallelList = ResizeArray<_>()
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            poolingValueTask {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow

tests/IcedTasks.Tests/TaskTests.fs

@@ -694,7 +694,7 @@ module TaskTests =
 
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            task {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow

tests/IcedTasks.Tests/ValueTaskTests.fs

@@ -691,7 +691,7 @@ module ValueTaskTests =
 
 
                         let fakeWork id yieldTimes (l: ResizeArray<_>) =
-                            valueTask {
+                            backgroundTask {
                                 lock l (fun () -> l.Add(id))
                                 do! Task.yieldMany yieldTimes
                                 let dt = DateTimeOffset.UtcNow