Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change coverage file pattern #191

Closed
halcwb opened this issue Feb 22, 2020 · 2 comments · Fixed by #207
Closed

Change coverage file pattern #191

halcwb opened this issue Feb 22, 2020 · 2 comments · Fixed by #207

Comments

@halcwb
Copy link
Contributor

halcwb commented Feb 22, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
When porting an existing library to the MiniScaffold template, I ran into a problem with generating a coverage report. I had added a new test project with just one framework setting. This generates a coverage xml like coverage.xml, instead of for example: coverage.net461.xml. However, with a name like coverage.xml, this is not picked up by the GenerateCoverageReport target.

Describe the solution you'd like
If you change the file glob pattern from !!"tests/**/coverage.*.xml" to !!"tests/**/coverage*.xml" then it works also in my scenario. (So, I just removed the .).

Describe alternatives you've considered
NA

Additional context
NA
@TheAngryByrd
Copy link
Owner

Nice catch! Feel free to send a pull request 😀

@halcwb
Copy link
Contributor Author

halcwb commented Feb 24, 2020

Thanks, I will.

@halcwb halcwb mentioned this issue May 1, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: test coverage file pattern halcwb/MiniScaffold
2 participants
@halcwb @TheAngryByrd