-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint suggestion: filtering SystemParams allowed in a SystemSet #104
Comments
I do think this is quite useful: making sure you don't put gameplay code in the wrong state or so in is important. We could also consider tying this sort of thing directly to states, or moving it fully to runtime schedule inspection. |
How would it work using states? For runtime schedule inspection, using bevyengine/bevy#11094 is probably a good idea. |
So, I think the states variant is probably a different lint, but being able to say "you should not be accessing certain data in a certain state" is an interesting customizable correctness check. Probably quite hard to configure though, so maybe not worth it. |
I'm looking for a way to filter the SystemParams allowed on systems added to a given SystemSet. @alice-i-cecile suggested I open a lint proposal here to discuss what a lint for this would look like.
Ideally the user would be able to define a SystemParam whitelist/blacklist filter on a SystemSet. The lint would then need to validate systems against this filter and deny the addition of that system to the set. This filtering probably also needs runtime validation, but the lint would be helpful ergonomically.
The text was updated successfully, but these errors were encountered: