Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style lints for system set naming convention #183

Open
alice-i-cecile opened this issue Nov 25, 2024 · 1 comment
Open

Add style lints for system set naming convention #183

alice-i-cecile opened this issue Nov 25, 2024 · 1 comment
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible

Comments

@alice-i-cecile
Copy link
Member

I think that these should end in Set, but opinions may vary! We should have a way to automatically and consistently enforce this. Related to #47.

Raised by @Jondolf on Discord:

Our system set naming is very inconsistent, there's Foo, FooSet, FooSystem, FooSteps

@alice-i-cecile alice-i-cecile added A-Linter Related to the linter and custom lints C-Feature Make something new possible labels Nov 25, 2024
@benfrankel
Copy link

benfrankel commented Nov 25, 2024

Also other naming conventions. See bevyengine/bevy#14274 for a summary of naming conventions within Bevy itself at the time the issue was created. For example, components not ending with Component is a convention that could have a lint. EDIT: I see that specific case is #47 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible
Projects
Status: Todo
Development

No branches or pull requests

3 participants