Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps support cargo-generate #1

Closed
janhohenheim opened this issue Jul 4, 2024 · 9 comments
Closed

Perhaps support cargo-generate #1

janhohenheim opened this issue Jul 4, 2024 · 9 comments
Labels
enhancement New feature or request uncontroversial This work is generally agreed upon
Milestone

Comments

@janhohenheim
Copy link
Member

Migrated from bevyengine/bevy_github_ci_template#59

@Sapein
Copy link
Collaborator

Sapein commented Jul 4, 2024

Either way, I do think supporting cargo generate would mostly provide some nice features while not necessarily requiring or taking away too much from just using this repository as a github template if we wanted to do that.

Also, Would this be better suited for a discussion? or should we keep this as an issue?

@janhohenheim
Copy link
Member Author

I think for small repos, having only issues keeps stuff more visible :)
Agreed, cargo generate would be very nice to have.

@Sapein
Copy link
Collaborator

Sapein commented Jul 5, 2024

Alright, so next question is: How much do we want to integrate with cargo-generate? Just basic integration, or do we want 'deeper' integration (such as, using conditionals and the like). If we go with deeper integration, we can do a lot more with it, BUT using the repo as a 'Github Repository Template' would be more tricky/less intuitive. Where-as if we keep it rather basic, then using this as a 'Github Repository Template' would have no issues.

@benfrankel
Copy link
Collaborator

IMO cargo-generate support should be added after #19, since some hack may be required to make the two features compatible, and having an itch.io page ASAP will be useful for testing.

@benfrankel benfrankel added blocked Requires work upstream uncontroversial This work is generally agreed upon and removed blocked Requires work upstream good first issue Good for newcomers labels Jul 6, 2024
@Sapein
Copy link
Collaborator

Sapein commented Jul 10, 2024

After doing some research, it seems like cargo-generate does not choke when ran on a repository that doesn't have anything in it. I also found a few different repositories that use github actions:

Not all of these use github actions directly (at least two support it, but don't run it on the main repo it seems), while two do. So we can probably look at these to see how they operate and how to integrate them into what we need.

@MiniaczQ MiniaczQ added the wontfix This will not be worked on label Jul 10, 2024
@MiniaczQ
Copy link
Collaborator

MiniaczQ commented Jul 10, 2024

Out of scope for 0.14 template
Will return to this topic when editor lands, see:
https://discord.com/channels/691052431525675048/1258521739395203174/1260625766572359790

@Sapein
Copy link
Collaborator

Sapein commented Jul 10, 2024

Out of scope for 0.14 template Will return to this topic when editor lands, see: https://discord.com/channels/691052431525675048/1258521739395203174/1260625766572359790

No it isn't. That was more-so talking about Bevy itself from what I could tell. This isn't bevy.

Furthermore it adds additional features that are useful. Please see the conversation immediately prior to that were more information on it was discussed.

@Sapein Sapein removed the wontfix This will not be worked on label Jul 10, 2024
@MiniaczQ
Copy link
Collaborator

Agreed in discord to maintain a cargo-generate branch which has the template variables

@janhohenheim
Copy link
Member Author

Done!
Run cargo generate TheBevyFlock/bevy-template --branch cargo-generate :)

@benfrankel benfrankel added this to the Bevy Jam 5 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uncontroversial This work is generally agreed upon
Projects
None yet
Development

No branches or pull requests

4 participants