Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS builds #112

Merged
merged 20 commits into from
Jul 11, 2024
Merged

Fix macOS builds #112

merged 20 commits into from
Jul 11, 2024

Conversation

janhohenheim
Copy link
Member

Resolves #48

@alice-i-cecile
Copy link
Member

Once this is validated please backport it to the CI template.

benfrankel
benfrankel requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review pass.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
janhohenheim and others added 2 commits July 11, 2024 20:00
@janhohenheim @benfrankel
Add period
ddbd098 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim
Use env.VERSION
1fb119d
@janhohenheim janhohenheim requested a review from benfrankel July 11, 2024 18:02
benfrankel
benfrankel requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, will review the big blob next.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
benfrankel
benfrankel requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@benfrankel benfrankel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Upload package to artifacts" step is missing from the MacOS job, so its release will not be uploaded to itch.io.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
janhohenheim and others added 8 commits July 11, 2024 20:47
@janhohenheim @benfrankel
Update release.yaml
951f69c 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
a006a98 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
fdd5b4d 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
fe2b15b 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
987c30c 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
7f5af0a 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
bbf35ba 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim @benfrankel
Update release.yaml
8eef101 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
janhohenheim and others added 3 commits July 11, 2024 20:53
@janhohenheim @benfrankel
Update release.yaml
ab801f5 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim
Ignore assets when empty
1d8f183
@janhohenheim
Fix missing artifacts
625a669
@janhohenheim janhohenheim requested a review from benfrankel July 11, 2024 21:08
benfrankel
benfrankel requested changes Jul 11, 2024
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@janhohenheim @benfrankel
Update .github/workflows/release.yaml
f38bea4 
Co-authored-by: Ben Frankel <ben.frankel7@gmail.com>
@janhohenheim janhohenheim requested a review from benfrankel July 11, 2024 21:09
benfrankel
benfrankel requested changes Jul 11, 2024
View reviewed changes
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@benfrankel benfrankel merged commit b4e7d4d into main Jul 11, 2024
3 checks passed
@benfrankel benfrankel deleted the macos branch July 11, 2024 21:12
@janhohenheim janhohenheim mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett left review comments

@benfrankel benfrankel benfrankel approved these changes

@MiniaczQ MiniaczQ Awaiting requested review from MiniaczQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix macOS builds
4 participants
@janhohenheim @alice-i-cecile @rparrett @benfrankel