feat: configurable default timeout and interval #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmkal
commented
Apr 5, 2019
| @@ -49,4 +54,4 @@ const waitForExpect = function waitForExpect( | |||
| }); | |||
| }; | |||
|
|
|||
| export default waitForExpect; | |||
| export default Object.assign(waitForExpect, { defaults }); | |||
There was a problem hiding this comment.
I attached defaults to the exported function rather than as a separate export so that it gets passed along for free when it's re-exported in react-testing-library or similar
|
Looks good, thank you! And sorry for the lag - I didn't notice this PR somehow. |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey - love the library! This is a very small PR to allow setting the default timeout and interval globally.
Was going to make an issue but I thought this was simple enough that a PR would be about as easy. Obviously up to you if you want this to go in - it's possible to workaround by wrapping this library's export, but I found myself doing that in a lot of projects, so I wondered if you'd be open to supporting it out-of-the box.
Side note - I noticed there's a file
src/index.d.ts, but I'm not sure what this does, since the declaration files are generated bynpm run build(which outputslib/index.d.ts, matching what's inpackage.json). I left it, but it could probably be safely deleted, along with the other*.d.tsfiles undersrc.