Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome Webfont #765

Closed
chsreedhar opened this issue May 6, 2017 · 4 comments
Closed

FontAwesome Webfont #765

chsreedhar opened this issue May 6, 2017 · 4 comments
Assignees
Milestone

Comments

@chsreedhar
Copy link

Am getting following error when Using PatternFly theame.
capture
It seems that FontAwesome Webfont files are missing in BootsFaces-OSP-1.1.0-dist.jar

@stephanrauh
Copy link
Collaborator

The FontAwesome files are not part of BootsFaces. By default, they are loaded from http(s)://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css.

I don't have any idea why your application tries to load FontAwesome as a JSF resource. We've updated to version 4.7.0 last November, so I don't believe it's a BootsFaces problem. Is there another JSF page or JSF framework trying to load FontAwesome 4.6.3 in your project?

@chsreedhar
Copy link
Author

chsreedhar commented May 11, 2017

BootsFaces Integrated with PrimeFaces-6.1 and context-parameter net.bootsfaces.get_fontawesome_from_cdn set to false in web.xml
The Request header Reference parameter shows http://sree/stds2/javax.faces.resource/css/patternfly/core.css?ln=bsf

This happens in case of BootsFaces_THEME set to patternfly.

capture2

@stephanrauh
Copy link
Collaborator

You're right, there's a reference to Font Awesome in the Patternfly CSS file.

@TheCoder4eu Is it possible to remove these lines from the core.css during the Gradle build?

@TheCoder4eu TheCoder4eu self-assigned this May 13, 2017
@TheCoder4eu TheCoder4eu added this to the v1.1.2 milestone May 13, 2017
@TheCoder4eu
Copy link
Owner

TheCoder4eu commented May 27, 2017

@stephanrauh , I'll drop the inclusion of Font Awesome CSS in the Patternfly CSS, but we must document that when using the patternfly theme , the context-parameter net.bootsfaces.get_fontawesome_from_cdn must be set to true in web.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants