Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose slider2 JS object to window #988

Closed
jepsar opened this issue Aug 8, 2018 · 2 comments · Fixed by #1005 or #1019
Closed

Expose slider2 JS object to window #988

jepsar opened this issue Aug 8, 2018 · 2 comments · Fixed by #1005 or #1019
Assignees
Milestone

Comments

@jepsar
Copy link
Contributor

jepsar commented Aug 8, 2018

Now there is no way to customize things.

"var " + VarName + "_sv = new Slider('#" + fClientId + "_slider', { " +

Could be changed to:

"window." + VarName + "_sv =....

And maybe even an attribute could be added to set your var name (if your slider is in a form without an id attribute, you get a generated id based variable name like j_idt8_slider_sv).

@stephanrauh You could assign this to me if you like.

@stephanrauh stephanrauh assigned stephanrauh and jepsar and unassigned stephanrauh Aug 9, 2018
@stephanrauh
Copy link
Collaborator

Sound's like you're about to send a pull request. Go ahead! The feature sounds sensible to me.

@jepsar
Copy link
Contributor Author

jepsar commented Oct 14, 2018

@stephanrauh This issue was not fixed in that PR, I'll provide a new PR fixing this issue. Please reopen for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants