Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Syn to 2.0 #408

Closed
Pat-Lafon opened this issue Apr 15, 2023 · 0 comments · Fixed by #409
Closed

Upgrade Syn to 2.0 #408

Pat-Lafon opened this issue Apr 15, 2023 · 0 comments · Fixed by #409
Assignees
Milestone

Comments

@Pat-Lafon
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I would like upgrade Inkwell's dependency of Syn to the next major release, 2.0. As other projects have updated, it's quite unfortunate to have 2 versions of Syn in my project dependency tree.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I would like to upgrade the Syn version to 2.0 and fix any of the breaking changes. I'll open a pr but the template says I should have an issue first.

Describe possible drawbacks to your solution
How might this solution hinder other components or users if implemented?

If some projects are still on Syn 1.0, then they will have multiple versions of Syn in their dependency tree.

Syn still supports a msrv of 1.56 but if this were to increase then that might affect Inkwells minimum version. I'm not 100% sure about how/when this could occur but I'll note it here.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

One could not upgrade but with major crates like clap doing so I'm not sure why one wouldn't.

Additional context
Add any other context or screenshots about the feature request here.

@Pat-Lafon Pat-Lafon mentioned this issue Apr 15, 2023
1 task
@TheDan64 TheDan64 linked a pull request Apr 15, 2023 that will close this issue
1 task
@TheDan64 TheDan64 added this to the 0.2.0 milestone Apr 15, 2023
@TheDan64 TheDan64 modified the milestones: 0.3.0, 0.2.0 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants