Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messed up RoadLanes in some scenarios #171

Open
TheDuckCow opened this issue Jun 18, 2024 · 0 comments
Open

Messed up RoadLanes in some scenarios #171

TheDuckCow opened this issue Jun 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TheDuckCow
Copy link
Owner

Copying over the unfinished work from #136 , we have some scenarios where RoadLanes don't get placed as they should and as the road textures would imply:

Documenting this as I've needed to summarize it for myself several times, and what I'm planning to do with it:

  • A: Two "next" RPs pointing to each other creates two overlapping sets of road lanes Screen Shot 2024-05-19 at 12 03 16 PM
    • Will try to at least skip adding one of the sets of RoadLanes, but tbh it still ends up very screwy because they criss-cross
    • "Normalizing" the container will solve this problem
  • B: Two "prior" RPs poing to each other creates a gap (regardless of lane transitions) Screen Shot 2024-05-19 at 12 07 38 PM
    • Nothing we can do about this, since it's one roadpoint which is the parent for RoadLanes that should go in both directions
    • "Normalizing" the road container will solve this
  • C: Some scenario where the curves all try to be attached to the "wrong side", even though this is already a "normalized" container Screen Shot 2024-05-19 at 12 05 03 PM
    • I just need to explore this one to find a solution, it's possible it's just messed up data in my test scene that can't be reproduced.
  • D: Adding and removing a lane on opposite sides within one segment Screen Shot 2024-05-19 at 9 29 59 AM
    • This is kind of separate to this ticket and more to do with lane matching being off.
    • For now the workaround is to just not do both adding and removing in the same segment, but it would be nice to allow for this since people might want to keep the road lane width consistent
    • Will log as its own bug

As mentioned, half of the items above would be fixed with "normalization" where we go through and see which roadpoints are most commonly in one particular direction, and then flip the direction and connections of all other roadpoitns (physically rotating them 180º) so that everything is now going in order.

@TheDuckCow TheDuckCow added the bug Something isn't working label Jun 18, 2024
@TheDuckCow TheDuckCow pinned this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant