Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x UndoRedo history mismatch editor errors #193

Open
TheDuckCow opened this issue Sep 28, 2024 · 1 comment · May be fixed by #200
Open

4.x UndoRedo history mismatch editor errors #193

TheDuckCow opened this issue Sep 28, 2024 · 1 comment · May be fixed by #200
Labels
4.x Issue affecting Godot 4.x bug Something isn't working
Milestone

Comments

@TheDuckCow
Copy link
Owner

With the upcoming version v0.5.1 per here, there's still a number of rogue error messages in this godot 4 version compared to 3.5, but they seem to have little or no consequence aside from being annoying.

One of those that I'm currently scratching my head at are these 4 which print out when using the UI buttons to add a RoadPoint:

  UndoRedo history mismatch: expected 0, got 2.
  UndoRedo history mismatch: expected 0, got 2.
  UndoRedo history mismatch: expected 0, got 2.
  UndoRedo history mismatch: expected 0, got 2.

Counter to what one might expect, undo and redo work perfectly fine even going back further steps and returning to the "do" step. There's also a bunch of errors with the first RoadPoint added when initially a RoadContainer is added. I think that one is happening due to Update Edges being called before the targeted RoadPoint is fully in the scene, thus getting some long UI editor path nodes that are ultimately invalid. The user doesn't face any consequence now as I ensure another call to Update Edges happens at the end of the action, but still - could be nice one day to clean up the errors.

@TheDuckCow TheDuckCow added the bug Something isn't working label Sep 28, 2024
@TheDuckCow
Copy link
Owner Author

Some of these errors turned out to actually still be in 3.5x too, resolved via this commit (3ea5dfe) which I'm also creating a parallel 4.x change for here. But the off undo/redo count errors still happen somewhat randomly.

@TheDuckCow TheDuckCow changed the title Non-consequential godot 4.x editor errors and warnings 4.x UndoRedo history mismatch editor errors Sep 29, 2024
@TheDuckCow TheDuckCow added the 4.x Issue affecting Godot 4.x label Oct 13, 2024
@TheDuckCow TheDuckCow added this to the v0.5.2 milestone Oct 13, 2024
@TheDuckCow TheDuckCow linked a pull request Oct 16, 2024 that will close this issue
@TheDuckCow TheDuckCow linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Issue affecting Godot 4.x bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant