Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] HIBP Analyser no longer works #524

Closed
znb opened this issue Aug 14, 2019 · 2 comments
Closed

[Bug] HIBP Analyser no longer works #524

znb opened this issue Aug 14, 2019 · 2 comments
Assignees
Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related
Milestone

Comments

@znb
Copy link

znb commented Aug 14, 2019

Describe the bug
On July 2019 they updated the API to use authentication. All queries will now fail.

To Reproduce
Steps to reproduce the behavior:

  1. Run the HIBP analyser
  2. ???
  3. Profit
  4. Nope.

Expected behavior
A valid response from the API.

Possible solutions
We need to update the analyser to take an API key in the configuration.

There will be changes to the analyser code:

  1. Change to the v3 API
  2. Adding in authentication header
@znb znb added the category:bug Issue is related to a bug label Aug 14, 2019
@mgabriel-silva
Copy link

Same problema here:
"errorMessage": "API Access error: This version of the API has been discontinued, please use V3: https://www.troyhunt.com/authentication-and-the-have-i-been-pwned-api/"

@jeromeleonard jeromeleonard self-assigned this Aug 27, 2019
@jeromeleonard
Copy link
Contributor

hello,

thanks to @jonashergenhahn for the PR #525 that should fix this. The new version of this analyzer has been merged in develop branch. As API subscription are temporary disabled I have not been able to test. Please make some test on your side and tell us if everything is fine.

@jeromeleonard jeromeleonard added the scope:analyzer Issue is analyzer related label Aug 27, 2019
@jeromeleonard jeromeleonard added this to the 2.2.0 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug scope:analyzer Issue is analyzer related
Projects
None yet
Development

No branches or pull requests

3 participants