Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] EmailRep #750

Closed
KRUXLEX opened this issue Apr 21, 2020 · 10 comments
Closed

[Bug] EmailRep #750

KRUXLEX opened this issue Apr 21, 2020 · 10 comments
Labels
category:bug Issue is related to a bug
Milestone

Comments

@KRUXLEX
Copy link

KRUXLEX commented Apr 21, 2020

Describe the bug
EmailRep doesn't support a APIKey. It isn't necessary but for free we have bigger limit of request

To Reproduce
Non

Expected behavior
Add this to script:

self.emailrep = self.get_param('config.key', None, 'Missing EmailRep API key') //emailrep = EmailRep('<your api key>')

Complementary information
documentation https://github.com/sublime-security/emailrep.io-python

Work environment
Doesn't necessery

Possible solutions
Fix

Additional context
nOpe.

@KRUXLEX KRUXLEX added the category:bug Issue is related to a bug label Apr 21, 2020
@dadokkio
Copy link
Contributor

Hi @KRUXLEX can you please check if the pull resolves the issue?

@KRUXLEX
Copy link
Author

KRUXLEX commented Apr 21, 2020

I will add it tomorrow and give you feedback

@dadokkio
Copy link
Contributor

thanks, also because I asked a key yesterday but I didn't receive any reply yet..
so I've written random code to test it 😃

@KRUXLEX
Copy link
Author

KRUXLEX commented Apr 22, 2020

__init__() takes 1 positional argument but 2 were given

@dadokkio
Copy link
Contributor

have you removed the old emailrep.py file and installed the emailrep library?

@KRUXLEX
Copy link
Author

KRUXLEX commented Apr 22, 2020

forgot pip3 install -r :D checked... Working but in cortex don't show field for key input

@dadokkio
Copy link
Contributor

Did you perform a refresh of all the analyzers in cortex?

@KRUXLEX
Copy link
Author

KRUXLEX commented Apr 22, 2020

Yea, I had problem with Docker. Fixed. I input ApiKey, I wil test that limit work. Give me time until tommorow.

@KRUXLEX
Copy link
Author

KRUXLEX commented Apr 23, 2020

Looks it working correctly. Dont know what is limit without api. But with cay it's start return 429 after 50 request.

@garanews garanews added this to the 2.7.0 milestone Apr 24, 2020
@garanews
Copy link
Contributor

fixed in 2.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants