Inconsistent wording between the login and user management pages

[saadkadhi]

Request Type

Bug

Work Environment

Question	Answer
OS version (server)	Ubuntu 16.04 LTS
OS version (client)	Mac OS X 10.12.1
TheHive version / git hash	2.9.0
Package Type	Binaries
Browser type & version	Chrome 54

Problem Description

There's a wording mismatch between the login and the user management pages which can lead to confusions.

In the login page, we ask the user to supply their username while the admin must supply a login and a User name (which should read "Full Name") in the user management page.

Steps to Reproduce

1. Load TheHive auth page and notice that the grey text is username
2. Connect as an admin
3. Click on the Admin > Users menu
4. Notice the multi-column view where users are listed: the first column is Login (which corresponds to the identifier the user must use to open a session), and the second is Username (which actually should read Full Name)

Possible Solutions

In ui/app/views/login.html, replace the place holder's value Username with Login.

In ui/app/views/partials/admin/users.html, replace 'User name' with 'Full Name' and the placeholder's value 'Username' with Full Name.

Complementary information

Screenshot of the login page:

Screenshot of the user management page:

[saadkadhi]

Fixed by 3b86445 and 93ac9a4