Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case and alert TTPs operations #268

Closed
nadouani opened this issue Dec 29, 2022 · 5 comments · Fixed by #271
Closed

Add case and alert TTPs operations #268

nadouani opened this issue Dec 29, 2022 · 5 comments · Fixed by #271

Comments

@nadouani
Copy link
Contributor

The CaseEndpoint class is missing methods to:

  • create a TTP (procedure)
  • find a list of TTPs
client.case.create_procedure()
client.case.find_procedures()
@nadouani nadouani added this to the 2.0.0b4 milestone Dec 29, 2022
@nadouani
Copy link
Contributor Author

@Kamforka is this something that can reuse existing methods?

@Kamforka
Copy link
Collaborator

@nadouani we have the following already:

client.procedure.create_in_case()
client.procedure.create_in_alert()
client.procedure.get()  # non-generic find

We can add a generic client.procedure.find() method in the procedure endpoint and we are basically covered completely.

Or if you prefer we can replicate the above mentioned methods in the alert and case endpoints.

@nadouani
Copy link
Contributor Author

@Kamforka it's more for consistency reasons. we have client.case.find_XYZ except for procedures. To be consistent we should add a find_procedures method

@Kamforka
Copy link
Collaborator

@nadouani should the below be the complete list that we need to add:

# case endpoint
client.case.create_procedure()
client.case.find_procedures()
# alert endpoint
client.alert.create_procedure()
client.alert.find_procedures()
# ttp endpoint
client.procedure.find()

?

@Kamforka Kamforka self-assigned this Jan 14, 2023
@Kamforka Kamforka added the 2.x label Jan 14, 2023
@Kamforka Kamforka linked a pull request Jan 14, 2023 that will close this issue
@nadouani
Copy link
Contributor Author

@Kamforka this list of methods looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants