Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get php executable path from "php.validate.executablePath" #34

Open
smertelny opened this issue Feb 28, 2019 · 1 comment
Open

Get php executable path from "php.validate.executablePath" #34

smertelny opened this issue Feb 28, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@smertelny
Copy link

Rather a proposal than an issue. I have configured the path to php executable with "php.validate.executablePath" in settings, but extension need to get it from it's own "symfony-vscode.phpExecutablePath".
Is there is any reason not to look for the first option before looking for own settings?

@TheNouillet
Copy link
Owner

Hello,

The reason behind the separate setting is for installations that have the project running on another environnement than the one VSCode is running on (eg : Docker, Vagrant, remote server etc...)

That said, having it on null by default and looking at php.validate.executablePath first is a good idea. I'm all for it.

@TheNouillet TheNouillet added this to the v1.1.0 milestone Mar 30, 2019
@TheNouillet TheNouillet added the enhancement New feature or request label Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants