Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove getting hired channel env var #565

Merged
merged 1 commit into from
Jul 10, 2024
Merged

chore: remove getting hired channel env var #565

merged 1 commit into from
Jul 10, 2024

Conversation

01zulfi
Copy link
Member

@01zulfi 01zulfi commented Jul 10, 2024

Because

#564

This PR

#564

Issue

Closes #564

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@01zulfi 01zulfi merged commit 9a5439a into main Jul 10, 2024
2 checks passed
@01zulfi 01zulfi deleted the chore/remove-channel-env branch July 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement - Document .env configuration and pre-requisite installs
2 participants
@01zulfi @MaoShizhong