Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dynamic Values for Webhooks (Push Notifications) #782

Open
Xosten opened this issue Apr 18, 2023 · 4 comments
Open

[Feature] Dynamic Values for Webhooks (Push Notifications) #782

Xosten opened this issue Apr 18, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Xosten
Copy link

Xosten commented Apr 18, 2023

Is your feature request related to a problem? Please describe.

As a user relying on NFTY for sending notifications, if I want to use it with my Obico instance, I can only send a defined message that isn't dynamic.

Describe the solution you'd like

As a user, when I set up my webhook I would like to be able to add dynamic values so I could have personalised notifications sent based on the related matter.

For example: https://ntfy.sh/topic/send?message={$OBICO-MESSAGE}&title={$OBICO-TITLE}&priority=3&tags=bell

Whereas for this example if the Benchy print is ready :

  • $OBICO-TITLE = Print Ready
  • $OBICO-MESSAGE = Your Benchy is ready

Or the print Benchy started:

  • $OBICO-TITLE = Print Started
  • $OBICO-MESSAGE = Benchy print in progress ETA 1:20PM

We could see more variables available to the user in order to customise as much as possible, like:

  • Printer Name
  • AI Watch Status
  • File Name

Describe alternatives you've considered
None at the current stage

Additional context
NTFY is not the only notification system we can see for this context, Gotify could also be another option.

iOS users that are self-hosting don't have access to print progress notifications. Webhooks could be the solution to bring such alerts to those users.

We could see the same as the Discord notification, where the difference lies in the ability to structure in a certain manner the messages.

@kennethjiang kennethjiang added the enhancement New feature or request label Apr 18, 2023
@kennethjiang
Copy link
Contributor

I like the idea behind it. But your proposal seems to be too limiting and specific to NTFY.

I'd like to propose these variable substitutes for now:

  • EVENT: "print-started", "print-finished", "failure-alert", etc.
  • PRINTER_NAME
  • GCODE_NAME

Does it work for you @Xosten

@Xosten
Copy link
Author

Xosten commented Apr 18, 2023 via email

@LeSauvage
Copy link

Is this feature under development? I've made a basic plugins working with NTFY, I could pursue it more if you guys require specific features / variables

@kennethjiang
Copy link
Contributor

Is this feature under development? I've made a basic plugins working with NTFY, I could pursue it more if you guys require specific features / variables

No it hasn't be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants