-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace otto with goja #2975
Labels
Milestone
Comments
htdvisser
added
the
c/application server
This is related to the Application Server
label
Jul 24, 2020
And while at it, it would be nice to add a Prometheus histogram to get some insight in how long those scripts take |
Let's do this in one go with #2670 |
I've spent a half day on this, and the conclusion so far is: https://github.com/dop251/goja
https://github.com/robertkrimen/otto
So, this neither are ideal. I would still opt to switch to I'm afraid we need to pick either to keep the builds simple for the open source distribution. |
This was referenced Aug 24, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
We should replace the unmaintained otto library with goja.
Refs #2670 and #2966
Why do we need this?
Because we should avoid unmaintained libraries, especially ones that we use to run arbitrary code.
The text was updated successfully, but these errors were encountered: