Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Adding external subtitles restarts video #3665

Closed
mkbhdana opened this issue Apr 7, 2024 · 2 comments · Fixed by #4158
Closed

[BUG]: Adding external subtitles restarts video #3665

mkbhdana opened this issue Apr 7, 2024 · 2 comments · Fixed by #4158
Assignees
@freeboub
Labels
7.0 Accepted Issue is confirmed and accepted by maintainers team bug

Comments

@mkbhdana
Copy link

mkbhdana commented Apr 7, 2024

Version

v6 (Beta)

What platforms are you having the problem on?

Android

Architecture

Old architecture

What happened?

A bug happened!

whenever adding external subtitles video restarts from position 0 or if startPosition is set than it will start video from that position.

Reproduction

repository link

Reproduction

Step to reproduce this bug are:

add external subtitles while playing video.
@mkbhdana mkbhdana added the bug label Apr 7, 2024
@freeboub
Copy link
Collaborator

freeboub commented Apr 7, 2024

This is an exoplayer limitation, the fix would be to move it source prop

@freeboub freeboub added the 7.0 label Apr 9, 2024
@freeboub freeboub mentioned this issue May 24, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This issue is stale because it has been open for 30 days with no activity. If there won't be any activity in the next 14 days, this issue will be closed automatically.

@github-actions github-actions bot added the stale Closed due to inactivity or lack or resources label Sep 9, 2024
@freeboub freeboub self-assigned this Sep 10, 2024
@freeboub freeboub added Accepted Issue is confirmed and accepted by maintainers team and removed stale Closed due to inactivity or lack or resources labels Sep 10, 2024
@freeboub freeboub mentioned this issue Sep 10, 2024
Merged
@freeboub freeboub linked a pull request Sep 11, 2024 that will close this issue
fix: refactor side loaded text tracks management #4158
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freeboub freeboub

Labels
7.0 Accepted Issue is confirmed and accepted by maintainers team bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: refactor side loaded text tracks management freeboub/react-native-video
2 participants
@freeboub @mkbhdana