Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Using showNotificationControls - title is referenced from mp3 file metadata, not source.metadata.title #3987

Closed
nickmcmillan opened this issue Jul 10, 2024 · 3 comments · Fixed by #4050

Comments

@nickmcmillan
Copy link

Version

6.3.0

What platforms are you having the problem on?

iOS

System Version

react native 0.73.6. iOS 17.5.1

On what device are you experiencing the issue?

Real device

Architecture

Old architecture

What happened?

When playing an mp3 file whilst using showNotificationControls, the controls display the "title" value stored in the mp3 file metadata. The value provided in the source prop is ignored.

If the mp3 file does not contain "title" metadata it works correctly.

iOS has the issue. Android works as expected.

Reproduction

No response

Reproduction

Add a value to the "title" metadata field for a given mp3 file (Apple Music is one app where you can do this).
Then specify the metadata.title value in source.
In the notification controls, notice that the value encoded in the mp3 takes precedence.

const source: ReactVideoSourceProperties = {
      uri: 'file:///example.mp3',
      metadata: {
        title: 'Love Me Do', // if the mp3 file contains "title" metadata, this property is ignored
        artist: 'The Beatles',
      },
    }

return (
  <Video
    source={source}
    showNotificationControls
  />
)
@KrzysztofMoch
Copy link
Member

I will look into this next week 👀

@KrzysztofMoch
Copy link
Member

Hey @nickmcmillan can you test #4050 ?

@nickmcmillan
Copy link
Author

@KrzysztofMoch perfect, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants