Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Not getting callback when fullscreen player is dismissed via controls #552

Closed
acgourley opened this issue Apr 4, 2017 · 17 comments
Closed
Labels
bug Platform: iOS stale Closed due to inactivity or lack or resources

Comments

@acgourley
Copy link

I would expect onVideoFullscreenPlayerWillDismiss or onVideoFullscreenPlayerDidDismiss to trigger, but they do not seem to be either on device or simulator.

Testing on iOS 10 with RN 41 and react-native-video 1.0.0

@qamil
Copy link

qamil commented Apr 21, 2017

Hey @acgourley
Looking at VideoManager.m, I had the same expectation.
After debugging things a little bit I discovered that these are the right props:

  • onFullscreenPlayerWillPresent
  • onFullscreenPlayerDidPresent
  • onFullscreenPlayerWillDismiss
  • onFullscreenPlayerDidDismiss

Hope this helps.

@ciriac
Copy link

ciriac commented Jun 27, 2017

Can confirm this works for me.

<Video onFullscreenPlayerWillDismiss={this._onFullscreenPlayerWillDismiss.bind(this)} />

@AnisDerbel
Copy link

AnisDerbel commented Aug 9, 2017

it's not working for me the callback onFullscreenPlayerWillDismiss

@GuillaumeMunsch
Copy link

This is still not working. Either onFullscreenPlayerWillDismiss or onFullscreenPlayerDidDismiss.
Tested with react-native-video: 3.2.1 and react-native: 0.57.5

@fukuball
Copy link

Not working with "react-native-video": "^4.2.0" and "react-native": "0.57.7"

@NickKotowski
Copy link

Not working with "react-native": "^0.57.3" and "react-native-video": "4.3.0" either

@thanhdevapp
Copy link

Not working with "react-native": "^0.57.7" and "react-native-video": "4.3.1"

@livfwd
Copy link

livfwd commented Jul 10, 2019

We're running into the same issue. Any updates on this?

@fubar
Copy link

fubar commented Jul 15, 2019

Based on my tests it seems like those events are only emitted when fullscreen mode is opened through the player's functionality (ie. presentFullscreenPlayer), but not via the expand icon in the upper left corner of the video. There seem to be various issues with fullscreen behaviour, such as #1319. Given how long these issues have been unresolved, I wouldn't hold my breath for them to be fixed anytime soon.

@CHaNGeTe CHaNGeTe changed the title Not getting callback when fullscreen player is dismissed [iOS] Not getting callback when fullscreen player is dismissed via controls Jul 15, 2019
@CHaNGeTe
Copy link
Contributor

Can you check on this PR?
#1669

@jeremyfrancis
Copy link

This is a serious problem. Is someone able to fix this?

@danlupascu
Copy link

I'm having the same problem - none of the callbacks are working, any chance this could be fixed?

@joaocosta9
Copy link

any updates on this?

@EgorGitHub11
Copy link

any updates?

@saadamjad
Copy link

any update please ? still facing same issues . these callbacks are not trigger
onFullscreenPlayerWillDismiss
onFullscreenPlayerDidDismiss

@jsaq007
Copy link

jsaq007 commented Jun 7, 2021

Having the same issue.. any news on a fix?

@hueniverse
Copy link
Contributor

Can someone please try out #2379 and let us know if it fixes the issue?

@hueniverse hueniverse added the stale Closed due to inactivity or lack or resources label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Platform: iOS stale Closed due to inactivity or lack or resources
Projects
None yet
Development

No branches or pull requests