Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-Bar Link Active Color #50

Closed
ghost opened this issue Nov 13, 2016 · 4 comments
Closed

Top-Bar Link Active Color #50

ghost opened this issue Nov 13, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 13, 2016

Hi,

there's currently a customizer color option "Top-Bar Active Color" but no "Top-Bar Link Active Color" that would set the color of .menu .active > a.

For example a black top bar background and white link color together with white active link background hides the text of the active link.

Could the color option "Top-Bar Link Active Color" be added? (For my purposes "Top-Bar Link Hover Color" could be reused to set the color of .menu .active > a but I imagine that these two should be separated in some cases.)

@tsquez
Copy link
Member

tsquez commented Nov 13, 2016

Hey there,

Def this can be done amigo and I have been wanting to do this for a while now but I keep forgetting.

I'll make this part of the next update. Thanks again for mentioning it. Its greatly appreciated.

@tsquez
Copy link
Member

tsquez commented Jan 31, 2017

Almost done with the 6.3 update, I hope to have this included in the update. Stay tuned. Thanks again for the input.

@tsquez tsquez added the FIXED! label Feb 12, 2017
@tsquez
Copy link
Member

tsquez commented Feb 12, 2017

Actually, removing Foundation active class from WP-Forge. I have opted to go with the built in current-menu-item that is built into WordPress. This is easier to style and looks a lot cleaner. See this post https://developer.wordpress.org/reference/functions/wp_nav_menu/

I think it looks great and I hope you do to 😉

@tsquez tsquez closed this as completed Feb 12, 2017
@ghost
Copy link
Author

ghost commented Feb 12, 2017

Sounds good. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant