Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stashing failsafes #280

Closed
jonpas opened this issue Feb 25, 2017 · 5 comments
Closed

Remove stashing failsafes #280

jonpas opened this issue Feb 25, 2017 · 5 comments
Labels
cleanup enhancement
Milestone
1.13.0

Comments

@jonpas
Copy link
Member

jonpas commented Feb 25, 2017

Remove some failsafes introduced in #277 due to how removeXCargo CBA functions work.

Once CBA 3.3.0 releases with updated removeXCargo functions.
@jonpas jonpas added the task label Feb 25, 2017
@jonpas jonpas added this to the 1.12.0 milestone Feb 25, 2017
@jonpas jonpas added cleanup and removed task labels Feb 25, 2017
@jonpas
Copy link
Member Author

jonpas commented May 17, 2017

removeItemCargo is still problematic.

@jonpas jonpas modified the milestones: 1.12.0, 1.13.0, 1.12.1 Jun 21, 2017
@jonpas
Copy link
Member Author

jonpas commented Jul 1, 2017 •
edited
Loading

CBA 3.4 also fixes removeItemCargo, should be able to remove all failsafes now.

@jonpas
Copy link
Member Author

jonpas commented Jul 5, 2017

Needs further work:

  • Item being stashed will also have all contents removed (additional argument to CBA functions to keep contents?)
  • Stash interface updates only selected item count, using CBA functions will not show them unless re-entering the menu

@jonpas jonpas modified the milestones: 1.13.0, 1.12.1 Jul 5, 2017
@jonpas
Copy link
Member Author

jonpas commented Jul 18, 2017 •
edited
Loading

Item being stashed will also have all contents removed (additional argument to CBA functions to keep contents?)

Pull requested in CBATeam/CBA_A3#726. Need to use new argument.

@jonpas jonpas mentioned this issue Aug 6, 2017
Merged
@jonpas
Copy link
Member Author

jonpas commented Aug 6, 2017

Stash interface updates only selected item count, using CBA functions will not show them unless re-entering the menu

Done in #303

@jonpas jonpas mentioned this issue Aug 6, 2017
Merged
@jonpas jonpas changed the title Remove some stashing failsafes Remove stashing failsafes Aug 6, 2017
@jonpas jonpas mentioned this issue Aug 6, 2017
Closed
@jonpas jonpas modified the milestones: 1.12.3, 1.13.0 Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup enhancement
Projects
None yet
Milestone
1.13.0
Development

No branches or pull requests
1 participant
@jonpas