Fix parsing OWM current data

[marcelstoer]

Follow-up to https://support.thingpulse.com/799/currentweather-openweathermap-shows-espaper-everything

The proposed fix is to drop the outer loop at https://github.com/ThingPulse/esp8266-weather-station/blob/master/src/OpenWeatherMapCurrent.cpp#L68. The more I think about it the less I understand what the benefit actually is. Checking for available data should be enough.

[G6EJD]

I agree , I studied the code and although I code mine identically, I’m now thinking the same. If there was significant amounts of data to stream the connection would not be dropped until the client had received it all (TCP handles that aspect), similarly for small amounts of data the fact that the connection was dropped after the transfer is irrelevant as the data is in the buffer and processed the same as usual.

It’s an interesting issue and not really a network issue as the behaviour is correct and neither is it a coding issue, but it could well be the .connected() status has until now been incorrect and the latest update 2.4.2 has changed things as you originally thought.

[marcelstoer]

@G6EJD @SuperEugen see the enlightening feedback in the linked core issue.

[SuperEugen]

Good! Thanks that you clarified that with the WiFiClient developers!

[G6EJD]

Good to hear the core was changed and that the testing we did concluded the same.
So now coding techniques need to change to accommodate this.
I shall have to re-programme myself :)

[sorriso93]

It is not clear to me if now the library has been fixed.... many thanks

[marcelstoer]

We‘ll close this once it‘s fixed.

[G6EJD]

I think no fix is required and this is now the new behaviour, which is correct in TCP terms, previously it was incorrect.

[marcelstoer]

We have to adjust this library.

[G6EJD]

My mistake, I was thinking of the ESP core

[marcelstoer]

1.6.3 is available for download and in the Arduino Library Manager.