Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ExpectTimeout() #15

Open
FrankReh opened this issue Dec 9, 2015 · 0 comments
Open

Document ExpectTimeout() #15

FrankReh opened this issue Dec 9, 2015 · 0 comments

Comments

@FrankReh
Copy link

FrankReh commented Dec 9, 2015

Reading the documentation and the test cases led me to believe there was no handling for the case of a timeout. But then I looked at your actual code and you do use the time.After() inside a select go idiom for a timeout option. Why not provide an example in your read me, or provide a test case?

This looks iike a very promising project. I wrote a ton of expect a long time ago and now that I'm into go, having a go version of expect is great. Amazing how few lines of go it takes to make something so useful.

Also, why not make the timeout error a global constant so the user could test the error received against it to handle the normal timeout case more cleanly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant