Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0.1 maybe a bug or something by getting serverhost from consul #1370

Closed
wsjun2016 opened this issue Nov 13, 2020 · 1 comment
Closed

16.0.1 maybe a bug or something by getting serverhost from consul #1370

wsjun2016 opened this issue Nov 13, 2020 · 1 comment

Comments

@wsjun2016
Copy link

wsjun2016 commented Nov 13, 2020

the source code below:
private Service BuildService(ServiceEntry serviceEntry, Node serviceNode) { return new Service( serviceEntry.Service.Service, new ServiceHostAndPort(serviceNode == null ? serviceEntry.Service.Address : serviceNode.Name, serviceEntry.Service.Port), serviceEntry.Service.ID, GetVersionFromStrings(serviceEntry.Service.Tags), serviceEntry.Service.Tags ?? Enumerable.Empty<string>()); }

when serviceNode is null,service host will be serviceEntry.Service.Address,the result is OK.
when serviceNode is not null,it will take the value of serviceNode.Name.That is what I want to talk about.
Why serviceNode.Name?Why not serviceNode.Address?
serviceNode.Name sometime will be other value which is not a IP ,but like 'agent-one' something.
serviceNode.Address is a IP which looks like '127.0.0.1'.
so one or more exceptions have been thrown when I debug the program.
exception message likes that:
Error Code: ConnectionToDownstreamServiceError Message: Error connecting to downstream service, exception: System.Net.Http.HttpRequestException: 不知道这样的主机。

Specifications

  • Version:16.0.1
@wsjun2016 wsjun2016 changed the title 16.0.1 maybe a bug or something by getting server host 16.0.1 maybe a bug or something by getting serverhost from consul Nov 13, 2020
@raman-m
Copy link
Member

raman-m commented Jun 15, 2024

Read Release Notes for version 23.3.0
It should be fixed!

@raman-m raman-m closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants