Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions Storage for CookieStickySessions #1408

Open
EliSyrota opened this issue Jan 4, 2021 · 1 comment · May be fixed by #1405
Open

Sessions Storage for CookieStickySessions #1408

EliSyrota opened this issue Jan 4, 2021 · 1 comment · May be fixed by #1405
Assignees
Labels
accepted Bug or feature would be accepted as a PR or is being worked on Load Balancer Ocelot feature: Load Balancer proposal Proposal for a new functionality in Ocelot

Comments

@EliSyrota
Copy link

EliSyrota commented Jan 4, 2021

Problem to solve

The current implementation of CookieStickySessions contains ConcurrentDictionary<string, StickySession> _stored where all the sessions are stored.
We faced a situation when we need to have a few Ocelot instances on-premise of the customer
and we have some services that enforces us to use CookieStickySessions for our Load Balancer (https://ocelot.readthedocs.io/en/latest/features/loadbalancer.html#cookiestickysessions).
Having several instances of Ocelot push us to add the ability to use CookieStickySessions for load balancing across these several Ocelot instances.
To do so we need to have an ability to inject our own session storage implementation for CookieStickySessions

New Feature

Sessions storage implementations for CookieStickySessions load balancer.
Add the ability to use CookieStickySessions for Load Balancer across these several Ocelot instances

Steps to Reproduce the Problem

  1. extract sessions collection from CookieStickySessions
  2. make a public interface for session storage so users can implement their own mechanism of storing user sessions such as distributed sessions storage etc.
  3. substitute CookieStickySessionsCreator to inject into CookieStickySessions own storage mechanism
@raman-m raman-m added proposal Proposal for a new functionality in Ocelot Load Balancer Ocelot feature: Load Balancer accepted Bug or feature would be accepted as a PR or is being worked on labels Jun 15, 2024
@raman-m
Copy link
Member

raman-m commented Nov 5, 2024

Hello, Eli!
Are you online?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Bug or feature would be accepted as a PR or is being worked on Load Balancer Ocelot feature: Load Balancer proposal Proposal for a new functionality in Ocelot
Projects
None yet
2 participants