Route wildcards get confused with query params

[karinehovhannisyan]

Hi, we lately faced a weird situation with wildcards and query params in Ocelot.

Expected Behavior

We would expect the wildcards to have no relation to anything that comes after the ? symbol and proceed the request as is.

Actual Behavior

If a route query parameter contains the value of the wildcard, its first symbol is truncated and the parameter name is changed.

Steps to Reproduce the Problem

Here is how we got this.

1. Added a route like this (some fields are missing here)

{
    "DownstreamPathTemplate": "/api/{version}/Companies/{companyId}/all",
    "DownstreamScheme": "http",
    "DownstreamHostAndPorts": [
      {
        ...
      }
    ],
    "UpstreamPathTemplate": "/api/{version}/Companies/{companyId}/all",
    "UpstreamHttpMethod": [ "Get" ],
  }

2. Make a request with this URL: http://localhost/api/v2/Companies/111/all?companyIds=111&companyIds=123
3. Our downstream receives the following params:

• ompanyIds - 111
• companyIds - 123

I also tried to add the {everything} after the ?, but then if one makes a call like this:
http://localhost/api/v2/Companies/111/all/?companyIds=111&companyIds=123

They receive a 404 error.

Specifications

• Version: 17.0.0
• Platform: .NET 5 application
• Subsystem:

[ghost]

Hi I am also facing the same , can anyone help me?

[raman-m]

It should be already fixed in v20.0
Are you interested in details?

[raman-m]

Hi @karinehovhannisyan!
This is well-known bug and it was fixed in v20.0, see commit ae43f32 and PR #1182 plz.

You need to re-define upstream template as following:

{
    "DownstreamPathTemplate": "/api/{version}/Companies/{companyId}/all?{everything}",
    "UpstreamPathTemplate": "/api/{version}/Companies/{companyId}/all?{everything}",
}

See more here 👉

• Catch All Query String

But...
Your both templates are identical! They are the same, no transformations, no changes at all.
In this case you can define one Catch All route:

{
    "DownstreamPathTemplate": "/{everything}",
    "UpstreamPathTemplate": "/{everything}",
}

It should route any URL with any query strings.

[raman-m]

Already fixed by #1182