-
Notifications
You must be signed in to change notification settings - Fork 286
Support TSSLSocket #136
Comments
Mentioned by Wes McKinney (author of Pandas) here: https://twitter.com/wesmckinn/status/672638289560539136 (he works on Ibis at Cloudera now) |
Yah we see it, hopefully we'll support it soon. |
SSLSocket supported now, it's actually more difficult than the first glance. The implementation in thriftpy should be better than the upstream apache lib:
While on the other hand, security is difficult and I'm not a security expert. I tried to implement the SSL socket based on best practice, there may still have bugs in it. So you may want to review the code before use, and I'll appricate any feedbacks on the implementation. |
@lxyu Very cool! I'm going to take a look next week. I also tweeted at Wes to let him know. |
@amontalenti Thanks, I'll make a release as soon as the review finished! |
Close as released in v0.3.3 |
Currently supported by
thrift
but notthriftpy
.The text was updated successfully, but these errors were encountered: