Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace variant="error" with variant="danger" #1175

Open
glenngijsberts opened this issue Aug 30, 2021 · 0 comments
Open

Replace variant="error" with variant="danger" #1175

glenngijsberts opened this issue Aug 30, 2021 · 0 comments
Assignees

Comments

@glenngijsberts
Copy link
Contributor

Improvement description

For our Alert component we're using the variant error, while we use danger for other components such as our Button component. It would be nice to align the two, so I would go for replacing error with danger.

Expected behaviour

Deprecate "error" variant for the Alert component & add "danger" variant instead. Use the "danger" variant inside the stories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants