Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding this to flathub #283

Open
ahzay opened this issue Aug 7, 2023 · 4 comments
Open

Adding this to flathub #283

ahzay opened this issue Aug 7, 2023 · 4 comments

Comments

@ahzay
Copy link

ahzay commented Aug 7, 2023

Hi,

I wrote a flatpak manifest json and I wanted to add it to flathub, however their documentation specifies that it is best to get in touch with the app developer so that they are in charge of it. If you are ok with it I'd like to add it in a pr, would it just be the required files in a directory at the root of the project of this repo which is also published on flathub? I'm new to contributing.

Thank you.

@Jermolene
Copy link
Member

Hi @ahzay and welcome to the project

I wrote a flatpak manifest json and I wanted to add it to flathub, however their documentation specifies that it is best to get in touch with the app developer so that they are in charge of it.

That's great, thank you, I'm sure it would be helpful for a lot of users to get TiddlyDesktop onto Flathub.

If you are ok with it I'd like to add it in a pr, would it just be the required files in a directory at the root of the project of this repo which is also published on flathub? I'm new to contributing.

It depends how many files need adding. The cleanest option would be to just add a dotfile in the root of the repo. If there are more than a couple of files then a subdirectory makes sense.

@ahzay
Copy link
Author

ahzay commented Aug 8, 2023

Hello, @Jermolene

It depends how many files need adding. The cleanest option would be to just add a dotfile in the root of the repo. If there are more than a couple of files then a subdirectory makes sense.

It's only two files, the JSON and the .desktop, I can also include a third one for building instructions. By dotfile do you mean a hidden folder?

@Jermolene
Copy link
Member

Thanks @ahzay I think perhaps it makes sense to put the files in a subdirectory. Is there an established subfolder that tools expect to find these files like .flatpak? (I am not familiar with Flatpak I'm afraid).

Should I also register a TiddlyWiki account with Flathub to own the listing?

@ahzay
Copy link
Author

ahzay commented Aug 8, 2023

@Jermolene I just realized that displaying inline images is broken in the flatpak, it only shows the small picture icon could be a dependency issue. I will try to fix this weekend and then report back.

Should I also register a TiddlyWiki account with Flathub to own the listing?

According to this to submit a listing you just make a pr. I guess there's no real need to include it in this repo, I can just give it to you once it's fixed. If you allow me to make the pr over there myself I wouldn't mind either, it's kind of a weird process they have of asking you to outright tell the maintainer of the application to also maintain a flatpak for it 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants