Fix type validation.

Author: teo-tsirpanis

sources/TileDB.CSharp/Array.cs

@@ -498,14 +498,14 @@ static void GetDomain<T>(Array array, string dimName, uint i, NonEmptyDomain non
         /// <exception cref="ArgumentException"><typeparamref name="T"/> is not the dimension's type.</exception>
         public (T Start, T End, bool IsEmpty) NonEmptyDomain<T>(uint index) where T : struct
         {
-            var datatype = EnumUtil.TypeToDataType(typeof(T));
             using (var schema = Schema())
             using (var domain = schema.Domain())
             using (var dimension = domain.Dimension(index))
             {
-                if (datatype != dimension.Type())
+                var datatype = dimension.Type();
+                if (EnumUtil.DataTypeToType(datatype) != typeof(T))
                 {
-                    throw new ArgumentException("Array.NonEmptyDomain, not valid datatype!");
+                    ThrowHelpers.ThrowTypeMismatch(datatype);
                 }
             }
 
@@ -528,14 +528,14 @@ static void GetDomain<T>(Array array, string dimName, uint i, NonEmptyDomain non
         /// <exception cref="ArgumentException"><typeparamref name="T"/> is not the dimension's type.</exception>
         public (T Start, T End, bool IsEmpty) NonEmptyDomain<T>(string name) where T : struct
         {
-            var datatype = EnumUtil.TypeToDataType(typeof(T));
             using (var schema = Schema())
             using (var domain = schema.Domain())
             using (var dimension = domain.Dimension(name))
             {
-                if (datatype != dimension.Type())
+                var datatype = dimension.Type();
+                if (EnumUtil.DataTypeToType(datatype) != typeof(T))
                 {
-                    throw new ArgumentException("Array.NonEmptyDomain, not valid datatype!");
+                    ThrowHelpers.ThrowTypeMismatch(datatype);
                 }
             }
 

sources/TileDB.CSharp/DimensionLabel.cs

@@ -129,7 +129,7 @@ public string GetUri()
         /// <inheritdoc/>
         public void Dispose()
         {
-            throw new NotImplementedException();
+            _handle.Dispose();
         }
     }
 }

sources/TileDB.CSharp/FragmentInfo.cs

@@ -651,7 +651,7 @@ private static void ValidateDomainType<T>(DataType dataType)
             {
                 ThrowHelpers.ThrowStringTypeMismatch(dataType);
             }
-            if (dataType != EnumUtil.TypeToDataType(typeof(T)))
+            if (EnumUtil.DataTypeToType(dataType) != typeof(T))
             {
                 ThrowHelpers.ThrowTypeMismatch(dataType);
             }

sources/TileDB.CSharp/Query.cs

@@ -913,7 +913,7 @@ public Tuple<ulong, ulong> FragmentTimestampRange(ulong idx)
 
         private void CheckDataType<T>(DataType dataType)
         {
-            if (EnumUtil.TypeToDataType(typeof(T)) != dataType)
+            if (typeof(T) != EnumUtil.DataTypeToType(dataType))
             {
                 if (!(dataType== DataType.StringAscii && (typeof(T)==typeof(byte) || typeof(T) == typeof(sbyte) || typeof(T) == typeof(string)))
                    && !(dataType == DataType.Boolean && typeof(T) == typeof(byte)))

sources/TileDB.CSharp/Subarray.cs

@@ -118,12 +118,11 @@ public void SetSubarray<T>(params T[] data) where T : struct
         public void SetSubarray<T>(ReadOnlySpan<T> data) where T : struct
         {
             ErrorHandling.ThrowIfManagedType<T>();
-            var dataType = EnumUtil.TypeToDataType(typeof(T));
             (var domainType, var nDim) = GetDomainInfo();
 
-            if (dataType != domainType)
+            if (EnumUtil.DataTypeToType(domainType) != typeof(T))
             {
-                ThrowHelpers.ThrowTypeMismatch(dataType);
+                ThrowHelpers.ThrowTypeMismatch(domainType);
             }
             if (data.Length != nDim * 2)
             {
@@ -141,23 +140,22 @@ public void SetSubarray<T>(ReadOnlySpan<T> data) where T : struct
         private void ValidateLabelType<T>(string name) where T : struct
         {
             ErrorHandling.ThrowIfManagedType<T>();
-            var dataType = EnumUtil.TypeToDataType(typeof(T));
             using var schema = _array.Schema();
             using var label = schema.DimensionLabel(name);
-            if (label.DataType != dataType)
+            if (EnumUtil.DataTypeToType(label.DataType) != typeof(T))
             {
-                ThrowHelpers.ThrowTypeMismatch(dataType);
+                ThrowHelpers.ThrowTypeMismatch(label.DataType);
             }
         }
 
         private void ValidateType<T>(string name) where T : struct
         {
             ErrorHandling.ThrowIfManagedType<T>();
-            var dataType = EnumUtil.TypeToDataType(typeof(T));
             using var schema = _array.Schema();
             using var domain = schema.Domain();
             using var dimension = domain.Dimension(name);
-            if (dimension.Type() != dataType)
+            var dataType = dimension.Type();
+            if (EnumUtil.DataTypeToType(dataType) != typeof(T))
             {
                 ThrowHelpers.ThrowTypeMismatch(dataType);
             }
@@ -166,11 +164,11 @@ private void ValidateType<T>(string name) where T : struct
         private void ValidateType<T>(uint index) where T : struct
         {
             ErrorHandling.ThrowIfManagedType<T>();
-            var dataType = EnumUtil.TypeToDataType(typeof(T));
             using var schema = _array.Schema();
             using var domain = schema.Domain();
             using var dimension = domain.Dimension(index);
-            if (dimension.Type() != dataType)
+            var dataType = dimension.Type();
+            if (EnumUtil.DataTypeToType(dataType) != typeof(T))
             {
                 ThrowHelpers.ThrowTypeMismatch(dataType);
             }