-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu install guide #1227
cpu install guide #1227
Conversation
Hi @Titus-von-Koeller . Do you think we could introduce users to installing the CPU backend bnb? Even though it can only be built from source for now, it could encourage more users to use the |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Hey @jiqing-feng, yeah, totally, that's why I added this addition to the README and was just waiting for you all to get back to me about the right timing, so that we can all post on socials to recruit alpha testers. Thanks a lot for adding these docs, that's a very helpful addition! The Intel backend should also be usable on Windows, right? Currently, it's only visible when having selected the Linux platform. You don't really see that when looking at the pure markdown, but the docs of the PR are live here. However, I also think it would make more sense to have a separate section at the "###" level with descriptive title and adapt that also to the Windows section, if that's supported. We can then also link to that section directly and people more easily find it when scanning the page. One other thing, could you please set up the pre-commit hooks as specified in our contributors guide and communicate that to the rest of your team as well? There were a few occasions where it was clear some of you don't have them enabled and it's an easy fix. It's pretty cool, the lint actually correctly caught a typo in your commit :) |
Copying over from my comment on the other PR :) # Installation
bitsandbytes provides broad backend support for CUDA, AMD ROCm, Intel CPU/GPUs, and Apple silicon.
## CUDA
### Compile from source
### PyTorch CUDA versions
## AMD ROCm
install instructions for Linux/Windows
include pointer for rocm pitfall here
## Intel CPU + GPU
To install bitsandbytes on a CPU backend:
<installation code here>
## Apple Silicon (MPS)
install instructions for Linux/Windows |
Hi @Titus-von-Koeller . Sorry for the delay, and thanks for your advice. I have fixed the code format, pls take a look. Actually, we haven't tested it on Windows, we will check it and get feedback to you soon. BTW, can I ask if you have any plans about merging multi-backend-refactor to the main? |
Hi @Titus-von-Koeller . I am working on Windows support. When we talk about Windows, do you mean a desktop or a server or both? BTW, I just notice that we actually don't have any C++ kernel in Intel CPU backend, so I didn't run cmake, and just
The log has no impact on functionality and performance. Do you think we could disable |
Hi @Titus-von-Koeller. We will need another PR to enable the int8 and 4bit path on Windows. We will enable the functionalities so that it won't break the commitment. However, performance is not guaranteed. Thanks. |
@jiqing-feng There is the CPU implementation for |
I agree, so can we merge this PR first to show users how to enable the CPU backend under the Linux system or wait until we support the Windows system? |
Hi @Titus-von-Koeller . I have added the Windows guide, but it requires the PR #1251 to be merged. Have you got the machine from Intel? If so, we can help to set up the runner. It would be nice if you could share your email with me; my email is jiqing.feng@intel.com; pls send me an email if you have any concerns. Thx. |
Hey all! Sorry, I've been off sick the last 10 days unfortunately. I'll look into this as soon as I can, gotta get back up to speed with things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, only a few suggestions to improve readability! 👍
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Hi @Titus-von-Koeller @stevhliu . Please take a review for my new changes. Thx! |
dada530
into
bitsandbytes-foundation:main
thanks @jiqing-feng and @stevhliu, LGTM, really appreciated! |
* cpu install guide * update readme * fix format * fix format * fix typo * add windows guide * fix readme to pip install . instead of building wheel * Update docs/source/installation.mdx Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Update docs/source/installation.mdx Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * Update docs/source/installation.mdx Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
This PR introduced a cpu install guide only for build from the source.