Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BeginString Tag 8 should be 8=FIX.4.x rather than 8=FIX4.x etc #50

Closed
NikolaosWakem opened this issue Sep 27, 2022 · 2 comments
Closed

BeginString Tag 8 should be 8=FIX.4.x rather than 8=FIX4.x etc #50

NikolaosWakem opened this issue Sep 27, 2022 · 2 comments

Comments

@NikolaosWakem
Copy link

There should be an extra . in the BeginString in the examples etc

e.g. 8=FIX.4.x rather than 8=FIX4.x etc

otherwise lots of headaches ;-)
@TimelordUK
Copy link
Owner

thanks for raising this. I have partially fixed this with config and some tests - some of tests will be quite time consuming to fix as we are checking exact buffer positions which would all fail.

@TimelordUK
Copy link
Owner

closing this now fixed thanks for raising issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NikolaosWakem @TimelordUK