Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send actions on user input only #13

Open
DivineDominion opened this issue Nov 2, 2019 · 3 comments
Open

send actions on user input only #13

DivineDominion opened this issue Nov 2, 2019 · 3 comments

Comments

@DivineDominion
Copy link
Contributor

This is just a suggestion pertaining the target/action mechanism, not KVO and delegates: when you change the date programmatically, do not invoke the target/action pair. That's more in line with programmatic changes to AppKit components like NSTextField.

In my case, this does not result in fetching the initial data twice, but by default it would if you populate the view with something and then have data for the same range requested again.

@MrMage
Copy link
Collaborator

MrMage commented Nov 11, 2019

I see your point; I guess I just wanted to have to handle value changes in one place only. Feel free to file a PR adding an option to not send events upon programmatic changes.

@DivineDominion
Copy link
Contributor Author

DivineDominion commented Nov 11, 2019 via email

@MrMage
Copy link
Collaborator

MrMage commented Nov 11, 2019

I would suggest keeping the current behavior; for most people it probably won't make a difference anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants