Weed Suppression

[Jayshua83]

Weed Suppression was used and now I have dots of weeds ALL over my fields! Is this intended?

[Jayshua83]

[Timmeey86]

This is not intended, I'll have to look into this. Can you let me know which map you were using and if this was with or without precision farming?

[Jayshua83]

Without PF.

Highly Edited version of Frankenmuth MI map. Although I don't think I changed any ground types or weed related things.

[Jayshua83]

I can send the zip too you if needed!

[Timmeey86]

I'd try and reproduce it on the unmodified map first. Could you tell me the last 4-5 things you did to the field? (e.g. harvested corn -> left barren for a bit -> planted oilseed radish -> rolled it down, or similar)

[Jayshua83]

Harvested Canola > Lime > Fertilizer > Oilseed Radish Seeded > Replanted Canola > Fertilizer Again

Settings were as follows.

[Jayshua83]

We got the Mulched Status from Planting Canola but Obviously with our settings and not reading it we had to fertilize a 2nd time since we already did a 1st stage ourselves and should have NOT done any Fert first... But we have a new Field Prep order now. lol :)

[Timmeey86]

Since you say "we", I guess this is multiplayer? If so, do you happen to have a backup save from before you seeded canola and could try if you get the same result if you seed canola in singleplayer?
I'll try reproducing it on my end in the meantime

[Jayshua83]

Yeah it is a Dedi Server with my wife and I. Not sure about saves. There have been a lot since... Might have overwritten by now... But I can try in SP later on...

[Jayshua83]

These were the first fields we have did since starting CA... We will have more later and I will be interested to see if they have similar results or if this is a one off or something...

[Timmeey86]

Some initial testing results:
The way I implemented weed suppression does not remove any weeds, it just prevents new ones.

So if you do

• Harvest canola
• Plant oilseed radish (OSR)
• Use weeder on OSR
• Sleep
• Seed Canola into OSR

you won't have any weeds

If you skip the weeding step, you'll have weeds in your OSR. If you direct seed into that, the weeds will not be visible, but still there, and the next month you'll see them again.

However, I guess it would make sense to have weed suppression terminate existing weeds, too, since they'd be crimped and also covered with the biomass from the OSR so they wouldn't get enough sunlight to recover maybe

[Jayshua83]

I thought OSR just didn't allow weeds cause I didn't see any. lol. Hrmph.. Well I might be able to turn that off in map xmls too if that is what is happening...

Although I think it is already set on most maps?

plantsWeed="false" is on OSR just like Grass/Meadow...

None of my other OSR fields have weeds...

[Jayshua83]

Also OSR cropCare maxWeederState="0" maxWeederHoeState="0" like Grass/Meadow...

[Timmeey86]

Ok yeah this is kind of weird. I did:

Elmcreek map, only my mod + easy def + real speed limit (to speed the test up)

1. Buy a canola field
2. Harvest a strip
3. Direct seed OSR into the strip and into the field a bit
4. Sleep
5. No weeds are shown in the map
6. Direct seed Canola into OSR, and on the harvested strip, and into the withered crop

Result: No visual weeds where there was OSR or withered crop
But the map shows weeds almost everywhere:

[Timmeey86]

Did a similar test with base game: The map behaves the same, but the weeds are visible in the field.
So it looks like my mod only removes the visual effects rather than the actual ones

[Timmeey86]

@Jayshua83 This should no longer happen. Please reopen if it does.
Note: I haven't published a release yet, since I'm testing the fertilization thing

[Timmeey86]

New release published: https://github.com/Timmeey86/FS22_ConservationAgriculture/releases/tag/v1.0.0.6