Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The xunit file is malformed int the passing case (0 tests) #6

Open
asymingt opened this issue May 1, 2023 · 0 comments
Open

The xunit file is malformed int the passing case (0 tests) #6

asymingt opened this issue May 1, 2023 · 0 comments

Comments

@asymingt
Copy link
Contributor

asymingt commented May 1, 2023

We noticed in CI that when ament_black tests pass our build goes green, but the interface that scrapes the XML file doesn't list any of the passing tests from black. This is a direct consequence of the fact that report argument passed to the xunit construction logic is empty, because it is built from the PatchSet, which in the passing case is empty.

Example from a test passing with 26 files:

<?xml version="1.0" encoding="UTF-8"?>
<testsuite  name="my_test_case.black" 
                   tests="0" 
                   errors="0" 
                   failures="0" 
                   time="0.233" >
    <system-out>Checked files:</system-out>
</testsuite>

This should be fixed to be brought inline with the other ROS linting tools.

@asymingt asymingt changed the title The xunit file produced by ament_black is malformed for the passing case The xunit file is malformed int the passing case (0 tests) May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant