Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible API typo: HWID #50

Open
ace-dent opened this issue Dec 29, 2022 · 2 comments
Open

Possible API typo: HWID #50

ace-dent opened this issue Dec 29, 2022 · 2 comments

Comments

@ace-dent
Copy link
Contributor

ace-dent commented Dec 29, 2022

When thumby.py imports thumbyHardware.py, it exposes IDPin.
This is likely a typo and should be HWID. There is no reason to make IDPin accessible through the API.
Affects both lib and lib-emulator versions (here & here).

@ace-dent
Copy link
Contributor Author

ace-dent commented Dec 29, 2022

Follow-up question: if HWID is available, should i2c and spi be accessible through the API? Why is it required to be exposed to third-party code? Should this be part of thumbyGraphics.py where initiation is self-contained just importing HWID (here).

@masonova1
Copy link
Collaborator

None of the software we've ever seen actually uses the ID pin, so I'm fine with deprecating it. We just need to de-duplicate HWID-getting code inside of main from thumbyHardware, and then we can get the HWID straight from thumbyHardware and remove the import. I'll do this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants